Query: Remove EntityQueryableExpressionVisitor and integrate function… #16299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
approved these changes
Jun 27, 2019
…ality in QueryableMethodTranslatingVisitor Issue: We did 2 pass in ExpressionTree to convert entityQueryables to shapedQueries and then translate/compose over them. Since we mutate the ShapedQueryExpression.QueryExpression in place, (reference to query expression are in shaper expression so it is not easy to make it immutable) if we try to translate something and fail then there is no way for us to try translating smaller part since we already mutated the ET. By integrating functionality in translation pipeline, if we fail to translate, our initial expression would still be intact (since it does not contain shapedQuery This is required for supporting collections/single non-scalar in projection.
Except for the subquery case This visitor should only translate methods on Queryable so it should not do base eval for others. All other methods should be passed through SqlTranslator (as they appear inside a lambda) For subquery, we don't want to throw since we don't know if the subquery has client methods or not (projection case) This is required for supporting collections/single non-scalar in projection.
smitpatel
force-pushed
the
smit/removeeqt
branch
from
11bd405 to
8c547e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ality in QueryableMethodTranslatingVisitor
Issue:
We did 2 pass in ExpressionTree to convert entityQueryables to shapedQueries and then translate/compose over them.
Since we mutate the ShapedQueryExpression.QueryExpression in place,
(reference to query expression are in shaper expression so it is not easy to make it immutable)
if we try to translate something and fail then there is no way for us to try translating smaller part since we already mutated the ET.
By integrating functionality in translation pipeline, if we fail to translate, our initial expression would still be intact (since it does not contain shapedQuery
This is required for supporting collections/single non-scalar in projection.