Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable test for issue#16231 #16345

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Enable test for issue#16231 #16345

merged 1 commit into from
Jun 28, 2019

Conversation

smitpatel
Copy link
Contributor

Closes #16231

AndriySvyryd
AndriySvyryd reviewed Jun 28, 2019
View reviewed changes
test/EFCore.Specification.Tests/Query/GearsOfWarQueryTestBase.cs Outdated
@@ -7205,7 +7205,7 @@ public virtual void Include_with_projection_of_unmapped_property_still_gets_appl
}
}

[ConditionalFact(Skip = "Issue#16231")]
[ConditionalFact]
public virtual Task Multiple_includes_with_client_method_around_qsre_and_also_projecting_included_collection()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@smitpatel smitpatel merged commit f9edba9 into master Jun 28, 2019
@ghost ghost deleted the smit/issue16231 branch June 28, 2019 22:03
@ajcvickers ajcvickers mentioned this pull request Jul 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@roji roji Awaiting requested review from roji

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query: Include on client projection gets ignored
2 participants
@smitpatel @AndriySvyryd