Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conditional expression handling entity equality visitor #16351

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Fix conditional expression handling entity equality visitor #16351

merged 1 commit into from
Jun 28, 2019

Conversation

roji
Copy link
Member

@roji roji commented Jun 28, 2019

This was quite silly...

Fixes #16335

smitpatel
smitpatel approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There there

@roji
Copy link
Member Author

roji commented Jun 28, 2019

BTW thought about having a visitor go over the tree after entity equality to make sure no nodes leak (like this case), to run only in DEBUG, but that still slows down all our tests.

@roji roji merged commit b7b3bc4 into master Jun 28, 2019
@ghost ghost deleted the WhereWithTypeCheck branch June 28, 2019 23:00
@ajcvickers ajcvickers mentioned this pull request Jul 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query: conditional operator with type check throws InvalidOperationException
2 participants
@roji @smitpatel