Query: Lift order by collection queries #16532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deleted the
roji
reviewed
Jul 29, 2019
| @@ -487,7 +488,7 @@ public void ClearOrdering() | |||
|
|
|||
| return shaperExpression; | |||
|
|
|||
| void HandleEntityMapping( | |||
| void handleEntityMapping( | |||
There was a problem hiding this comment.
@smitpatel @ajcvickers do we have a convention where local functions are camel-cased? From what I can see in samples, pascal case is used just like any other function.
There was a problem hiding this comment.
I think they should be pascal case, but we agreed to decide after 3.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.