Added some infrastructure and coverage for ASP.NET models #16579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would have allowed us to catch issues like dotnet/aspnetcore#12097 Part of #11838 Ideally, we should reference the actual "product" assemblies, but this requires changes to dependencies that I don't want to take on write now. #11838 is still open to track improvements. I intend to add some more tests here before 3.0 to get some more coverage.
AndriySvyryd
approved these changes
Jul 11, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would have allowed us to catch issues like dotnet/aspnetcore#12097
Part of #11838
Ideally, we should reference the actual "product" assemblies, but this requires changes to dependencies that I don't want to take on write now. #11838 is still open to track improvements.
I intend to add some more tests here before 3.0 to get some more coverage.