Cosmos: Add embedded collection support #16631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
CosmosCollections
branch
2 times, most recently
from
67a8e0f
to
ce9357e
Compare
smitpatel
reviewed
Jul 17, 2019
smitpatel
reviewed
Jul 17, 2019
smitpatel
reviewed
Jul 17, 2019
src/EFCore.Cosmos/Query/Pipeline/CosmosShapedQueryCompilingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Jul 17, 2019
src/EFCore.Cosmos/Query/Pipeline/CosmosShapedQueryCompilingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Jul 17, 2019
src/EFCore.Cosmos/Query/Pipeline/CosmosShapedQueryCompilingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Jul 17, 2019
src/EFCore.Cosmos/Query/Pipeline/CosmosSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
force-pushed
the
CosmosCollections
branch
from
ce9357e
to
fd94c61
Compare
|
@smitpatel Updated and rebased |
smitpatel
reviewed
Jul 18, 2019
smitpatel
reviewed
Jul 18, 2019
| Expression.MakeMemberAccess(entry, _entityTypeMemberInfo))), | ||
| MaterializeEntity(entityType, materializationContextVariable, concreteEntityTypeVariable, instanceVariable)))); | ||
| Expression.MakeMemberAccess(entryVariable, _entityTypeMemberInfo)), | ||
| Expression.Assign(instanceVariable, Expression.Convert( |
There was a problem hiding this comment.
Any significance of different ordering now?
There was a problem hiding this comment.
Consistency. The other blocks end with the instance.
smitpatel
reviewed
Jul 18, 2019
| Expression.MakeMemberAccess(entryVariable, _entityMemberInfo), | ||
| entityType.ClrType))), | ||
| MaterializeEntity( | ||
| entityType, materializationContextVariable, concreteEntityTypeVariable, instanceVariable, entryVariable)))); |
There was a problem hiding this comment.
How are we using entry variable
There was a problem hiding this comment.
To set IsLoaded later
smitpatel
reviewed
Jul 18, 2019
| return new ProjectionBindingExpression( | ||
| _selectExpression, _selectExpression.AddToProjection(translation), expression.Type); | ||
| } | ||
| //return _selectExpression.AddCollectionProjection( |
There was a problem hiding this comment.
Should remove commented code
There was a problem hiding this comment.
But we'll need it for non-cross-partition joins
smitpatel
reviewed
Jul 18, 2019
src/EFCore.Cosmos/Query/Pipeline/CosmosProjectionBindingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Jul 18, 2019
src/EFCore.Cosmos/Query/Pipeline/CosmosProjectionBindingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
force-pushed
the
CosmosCollections
branch
from
fd94c61
to
04b90b5
Compare
AndriySvyryd
force-pushed
the
CosmosCollections
branch
from
04b90b5
to
7d4b425
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatten out shaper expression visitors
Don't expand owned collection
Fixes #16620
Part of #12086