Cosmos API review changes #16685
Merged
Cosmos API review changes #16685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
force-pushed
the
WhatDoTheyCallItInTheParallelCosmos0719
branch
from
19f49c4
to
6a71e31
Compare
|
Team: since Andriy is out, could one of you sign off on this. I don't think there is anything controversial. |
ajcvickers
force-pushed
the
WhatDoTheyCallItInTheParallelCosmos0719
branch
from
6a71e31
to
3fea14e
Compare
|
I'm going to merge this to unblock work on the query API review changes. @AndriySvyryd Please take a look when you get back. |
|
Looking into this. |
smitpatel
reviewed
Jul 22, 2019
src/EFCore.Cosmos/Extensions/CosmosDbContextOptionsExtensions.cs
Outdated
Show resolved
Hide resolved
|
Thanks @smitpatel |
* Made `GetCosmosPartitionKeyStoreName` internal * `GetCosmosDefaultContainerName` -> `GetCosmosDefaultContainer` * Remove `Cosmos` from public namespaces to align with core * Make types internal to align with other providers Also, enabled API consistency tests and added some doc comments
ajcvickers
force-pushed
the
WhatDoTheyCallItInTheParallelCosmos0719
branch
from
3fea14e
to
0c72b18
Compare
ghost
deleted the
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetCosmosPartitionKeyStoreNameinternalGetCosmosDefaultContainerName->GetCosmosDefaultContainerCosmosfrom public namespaces to align with coreAlso, enabled API consistency tests and added some doc comments