Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some code cleanup in RelationalSqlTranslatingExpressionVisitor #16694

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Some code cleanup in RelationalSqlTranslatingExpressionVisitor #16694

merged 1 commit into from
Jul 31, 2019

Conversation

roji
Copy link
Member

@roji roji commented Jul 22, 2019

Plus some minor code cleanup

@roji roji requested a review from smitpatel July 22, 2019 20:43
smitpatel
smitpatel requested changes Jul 22, 2019
View reviewed changes
Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hold.

@roji roji changed the title Support DateTime subtraction into TimeSpan Some code cleanup in RelationalSqlTranslatingExpressionVisitor Jul 22, 2019
@roji
Copy link
Member Author

roji commented Jul 22, 2019

Removed the DateTime subtraction logic, left some code cleanup.

ajcvickers
ajcvickers requested changes Jul 29, 2019
View reviewed changes
Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to re-target to release/3.0 before merging.

@roji roji changed the base branch from master to release/3.0 July 30, 2019 08:24
@roji
Copy link
Member Author

roji commented Jul 30, 2019

@ajcvickers done

@smitpatel
Copy link
Member

Can you resolve merge conflicts and let the checks run again?

@roji roji requested a review from dougbu as a code owner July 30, 2019 19:19
@roji roji requested a review from smitpatel July 30, 2019 22:11
@roji roji merged commit 6a8ecc8 into release/3.0 Jul 31, 2019
@ghost ghost deleted the DateTimeSubtraction branch July 31, 2019 00:14
@ajcvickers ajcvickers mentioned this pull request Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers requested changes

@smitpatel smitpatel smitpatel approved these changes

@dougbu dougbu Awaiting requested review from dougbu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roji @smitpatel @ajcvickers