API review: add interception for DbCommand creation #16716
Conversation
|
@roji @smitpatel Could one of you review this since there are not many people not on vacation right now. :-) |
src/EFCore.Relational/Diagnostics/CommandCorrelatedEventData.cs
Outdated
Show resolved
Hide resolved
| @@ -75,16 +74,17 @@ public virtual int ExecuteNonQuery(RelationalCommandParameterObject parameterObj | |||
| { | |||
| var (connection, context, logger) = (parameterObject.Connection, parameterObject.Context, parameterObject.Logger); | |||
|
|
|||
| var command = CreateCommand(connection, parameterObject.ParameterValues); | |||
| var commandId = Guid.NewGuid(); | |||
There was a problem hiding this comment.
Ideally we'd only do this if we have interceptors configured (GUID generation unfortunately isn't free, e.g. dotnet/coreclr#1738 (comment)) but this is likely negligible.
|
|
||
| var command = connection.DbConnection.CreateCommand(); | ||
| var startTime = DateTimeOffset.UtcNow; | ||
| var stopwatch = Stopwatch.StartNew(); |
There was a problem hiding this comment.
Am curious - IIRC usually start/end activities and durations are calculated by EventSource/DiagnosticSource (have no idea to what extent we support activities in those etc).
Note that StopWatch is an additional allocation for every command creation that won't actually be needed for the general case.
There was a problem hiding this comment.
Last I was aware of, activities don't work for interleaved events. (That is, when, for example, multiple commands are created before any of them finish.)
I added a note to #16197 about perf.
There was a problem hiding this comment.
I'm no expert but I seem to remember that interleaved activities are possible, at least with EventSource - an ActivityID is used to correlate between start and stop (we'd use the GUID here). See this post.
ajcvickers
force-pushed
the
NotYourDaddysSopwithPup0723
branch
from
333038d
to
ffd6df3
Compare
ghost
deleted the
Fixes #16715