IsSqlServer etc migrationBuilder extensions #16956
Merged
+114
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
(Rebased on top of release/3.0) |
bricelam
reviewed
Aug 5, 2019
src/EFCore.SqlServer/Extensions/SqlServerMigrationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
bricelam
reviewed
Aug 5, 2019
| /// <param name="migrationBuilder"> The migrationBuilder from the parameters on <see cref="Migration.Up(MigrationBuilder)" /> or <see cref="Migration.Down(MigrationBuilder)" />. </param> | ||
| /// <returns> True if SQL Server is being used; false otherwise. </returns> | ||
| public static bool IsSqlServer([NotNull] this MigrationBuilder migrationBuilder) | ||
| => migrationBuilder.ActiveProvider.Equals( |
There was a problem hiding this comment.
ActiveProvider may be null. Best to use the static string.Equals()
bricelam
approved these changes
Aug 5, 2019
|
@bricelam this cannot be merged until the license bot is satisfied |
|
@dougbu I'm aware |
How do i know when to target master or release/x.0? |
Start on the repo's default branch (currently release/3.0). It changes depending on how close we are to releasing or how soon we start working on the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrations: Add IsSqlServer, etc. to MigrationBuilder
Fixes #8566