Compare Queryable operators by MethodInfo #17012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Aug 7, 2019
src/EFCore/Query/Internal/EntityEqualityRewritingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Query/QueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Query/QueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore/Query/QueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
roji
force-pushed
the
QueryableMethodLookup
branch
2 times, most recently
from
1d689f7 to
01be4aa
Compare
smitpatel
reviewed
Aug 8, 2019
src/EFCore/Query/QueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
Part of #16300, not exhaustive
roji
force-pushed
the
QueryableMethodLookup
branch
from
01be4aa to
f93ec50
Compare
smitpatel
approved these changes
Aug 8, 2019
ghost
deleted the
smitpatel
reviewed
Aug 8, 2019
roji
added a commit
that referenced
this pull request
Aug 8, 2019
roji
added a commit
that referenced
this pull request
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #16300, not exhaustive
Takes care of the big dispatching switches in QueryableMethodTranslatingEV, NavigationExpandingEV, EntityEqualityRewritingEV.
Some work should still be done to make QueryableMethodProvider itself more future-proof, and also to compare Enumerable operators by MethodInfo.