More fixes to entity equality nullability handling #17058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
approved these changes
Aug 9, 2019
| @@ -1278,6 +1278,28 @@ public override async Task List_Contains_with_parameter_list(bool isAsync) | |||
| WHERE ((c[""Discriminator""] = ""Order"") AND (c[""OrderID""] = 10248))"); | |||
| } | |||
|
|
|||
| [ConditionalTheory(Skip = "Issue#14935 (Contains not implemented)")] | |||
There was a problem hiding this comment.
nit: Contains does not have translation in cosmos. It is less of not implemented and more of client eval.
There was a problem hiding this comment.
Yeah, I was just following the way previous Contains tests were skipped. Am going to merge as-is, and can submit a PR to return Task.Complete instead of skipping.
/cc @AndriySvyryd
There was a problem hiding this comment.
It's alright. We want skip only rather than Task.Completed. It's just skip message was somewhat misleading. But test code so no big deal.
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16972
Continues work in #16957