Collection include for the in-memory provider #17089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
force-pushed
the
VeryInclusiveKenny0807
branch
from
d0ff183 to
3f20978
Compare
smitpatel
reviewed
Aug 12, 2019
src/EFCore.InMemory/Query/Internal/CustomShaperCompilingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Aug 12, 2019
src/EFCore.InMemory/Query/Internal/InMemoryProjectionBindingExpressionVisitor.cs
Show resolved
Hide resolved
smitpatel
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
Commented on couple of things. I don't think it is much worth trying to resolve them for InMemory since it is purely testing database. But I am fine either way.
@AndriySvyryd - would sign off for concurrency changes.
|
@AndriySvyryd Yes, it does fix that issue, although there may still need to be further improvements if we find there are async cases that we don't handle. |
ajcvickers
force-pushed
the
VeryInclusiveKenny0807
branch
from
3f20978 to
456efe7
Compare
This was referenced Aug 12, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #16963