Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid deadlock in tests #17155

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Avoid deadlock in tests #17155

merged 1 commit into from
Aug 15, 2019

Conversation

AndriySvyryd
Copy link
Member

Instead throw an exception

Part of #17019

@AndriySvyryd
Copy link
Member Author

Seems that the underlying issue is dotnet/SqlClient#85

@smitpatel
Copy link
Member

I put retry for the build to see if we have consistent repro for that.

@AndriySvyryd
Copy link
Member Author

I also got it locally

@AndriySvyryd
Copy link
Member Author

Yup, it reproes consistently

@ajcvickers
Copy link
Member

@AndriySvyryd I think I need a bit more details on the connection here. Can wait until I'm in the office tomorrow.

@ajcvickers
Copy link
Member

/cc @divega for the SqlClient connection.

@AndriySvyryd
Copy link
Member Author

@ajcvickers See https://dev.azure.com/dnceng/public/_build/results?buildId=310306&view=ms.vss-test-web.build-test-results-tab&runId=8949696&paneView=debug&resultId=100719

@AndriySvyryd AndriySvyryd merged commit a9e4766 into release/3.0 Aug 15, 2019
@ghost ghost deleted the 17019Part branch August 15, 2019 22:13
@ajcvickers ajcvickers mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriySvyryd @smitpatel @ajcvickers