Final API review polish changes #17166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ajcvickers
commented
Aug 15, 2019
ajcvickers
commented
- Remove GetSetter and GetMaterializationSetter from PropertyBaseExtensions (not used)
- Replace ExpressionExtensions.IsEFProperty with MethodInfo extension
- Verified MemberIdentity is not exposed on public APIs
- MemberIdentity Create(Navigation) => MemberIdentity Create(INavigation)
- IsNonNullableRefType => IsNonNullableReferenceType
- Remove overrides of Expression.CanReduce
- IPrintable => IPrintableExpression
- NullConditionalExpression updates for equality
- Remove TranslateResultSelectorForGroupJoin
- Looked at removing Type from RegisterRuntimeParameter, but it is needed
- Make IConcurrencyDetector - used by providers
- Added QueryContext.SetIsLoaded to avoid using internal StateManager
- Marked StartTracking and StateManager on QueryContext as internal (They aren't used by providers)
- QueryOptimizer => QueryTranslationPreprocessor
- ShapedQueryOptimizer => QueryTranslationPostprocessor
* Remove GetSetter and GetMaterializationSetter from PropertyBaseExtensions (not used) * Replace ExpressionExtensions.IsEFProperty with MethodInfo extension * Verified MemberIdentity is not exposed on public APIs * MemberIdentity Create(Navigation) => MemberIdentity Create(INavigation) * IsNonNullableRefType => IsNonNullableReferenceType * Remove overrides of Expression.CanReduce * IPrintable => IPrintableExpression * NullConditionalExpression updates for equality * Remove TranslateResultSelectorForGroupJoin * Looked at removing Type from RegisterRuntimeParameter, but it is needed * Make IConcurrencyDetector - used by providers * Added QueryContext.SetIsLoaded to avoid using internal StateManager * Marked StartTracking and StateManager on QueryContext as internal (They aren't used by providers) * QueryOptimizer => QueryTranslationPreprocessor * ShapedQueryOptimizer => QueryTranslationPostprocessor
ajcvickers
requested review from
smitpatel,
roji,
AndriySvyryd,
bricelam and
maumar
AndriySvyryd
approved these changes
Aug 15, 2019
ghost
deleted the
smitpatel
reviewed
Aug 15, 2019
| @@ -43,7 +43,7 @@ public static MemberIdentity Create([CanBeNull] string name) | |||
| public static MemberIdentity Create([CanBeNull] MemberInfo property) | |||
| => property == null ? None : new MemberIdentity(property); | |||
|
|
|||
| public static MemberIdentity Create([CanBeNull] Navigation navigation) | |||
| public static MemberIdentity Create([CanBeNull] INavigation navigation) | |||
There was a problem hiding this comment.
Shouldn't this be extension method over INavigation?
smitpatel
reviewed
Aug 15, 2019
| /// </summary> | ||
| /// <param name="entity"> The entity instance. </param> | ||
| /// <param name="navigation"> The navigation property. </param> | ||
| public virtual void SetIsLoaded([NotNull] object entity, [NotNull] INavigation navigation) |
There was a problem hiding this comment.
SetIsLoaded querycontext is bit ambiguous. For entry it makes sense. It should be renamed to something more appropriate. May be SetNavigationIsLoaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.