Don't call SqliteConnection.RemoveCommand() from command finalizer #17269
Conversation
| command.Dispose(); | ||
| } | ||
| else | ||
| { | ||
| _commands.RemoveAt(i); |
There was a problem hiding this comment.
NB: Only trimming the list on connection.Close/Dispose() now, not command.Dispose()
|
Hello, I am having this same issue, but I am only getting it from an IHostedService. The hosted service is using the DbContext after creating a scope from the service provider (all within "using" statements). As the hosted service is basically spamming the database, this is what seems to cause the issue. Without fail, it always errors when the method SqliteConnection.RemoveCommand is called in the stack trace, no matter the origin of the call (happens after SqliteCommand.Dispose). The error could happen from: DbContext.Database.EnsureCreated, DbContext.Set<>.Find or generally any query from the DbSet. The exception message is always "Object reference not set to an instance of the object", but there are no objects in my control that are null, it seems like an SQLite framework issue. I am using Microsoft.EntityFrameworkCore.Sqlite v3.1.0 in .NET Core 3.1. Running other integration tests via the WebApplicationFactory and replacing the provider with SQLite runs fine and works as I expect - I am using SQLite for testing to take advantage of the relational constraints it provides unlike the EF core in memory solution. |
|
@TharisSolutionsLtd Please file a new issue and include a small, runnable project that reproduces the behavior you are seeing so that we can investigate. |
Wrote a test locally to generate lots of garbage. This fixed a NullRef. Still couldn't repro #16234