Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for #9742 #17402

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Test for #9742 #17402

merged 1 commit into from
Aug 23, 2019

Conversation

AndriySvyryd
Copy link
Member

Resolves #9742

@AndriySvyryd AndriySvyryd requested a review from smitpatel August 23, 2019 18:39
smitpatel
smitpatel reviewed Aug 23, 2019
View reviewed changes
test/EFCore.Specification.Tests/Query/IncludeTestBase.cs
[ConditionalTheory]
[InlineData(false)]
[InlineData(true)]
public virtual void Include_collection_with_multiple_conditional_order_by(bool useString)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assert the sql

@AndriySvyryd AndriySvyryd merged commit 7f65331 into release/3.1 Aug 23, 2019
@ghost ghost deleted the Issue9742 branch August 23, 2019 21:46
@ajcvickers ajcvickers mentioned this pull request Aug 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndriySvyryd @smitpatel