Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InMemory: Set operations #17446

Merged
merged 1 commit into from
Aug 27, 2019
Merged

InMemory: Set operations #17446

merged 1 commit into from
Aug 27, 2019

Conversation

roji
Copy link
Member

@roji roji commented Aug 27, 2019

Part of #16963

@roji roji changed the title InMemory: Set operation InMemory: Set operations Aug 27, 2019
@roji
Copy link
Member Author

roji commented Aug 27, 2019

@smitpatel: EntityMaterializerSource.TryReadValue accepts an IPropertyBase parameter but doesn't use it, should we get rid of it?

@smitpatel
Copy link
Contributor

@smitpatel: EntityMaterializerSource.TryReadValue accepts an IPropertyBase parameter but doesn't use it, should we get rid of it?

No. We did that and we added it back. It does not use in method body. But when you convert things to read from server, IPropertyBase provides typeMapping.

@smitpatel
Copy link
Contributor

#14042 will require the property to flow to outermost level in read value.

smitpatel
smitpatel reviewed Aug 27, 2019
View reviewed changes
src/EFCore.InMemory/Query/Internal/InMemoryQueryableMethodTranslatingExpressionVisitor.cs
var inMemoryQueryExpression2 = (InMemoryQueryExpression)source2.QueryExpression;

// Apply any pending selectors, ensuring that the shape of both expressions is identical
// prior to applying the set operation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works when shapes are really identical. (what we support right now). For any EntityType differences, this would not work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the idea is to implement that at the same time for relational and InMemory when the time comes.

@roji roji merged commit 7b264f2 into feature/in-memory Aug 27, 2019
@ghost ghost deleted the InMemorySetOperations branch August 27, 2019 18:13
@ajcvickers ajcvickers mentioned this pull request Aug 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roji @smitpatel