Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove System.Threading.Tasks.Extensions #17483

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Remove System.Threading.Tasks.Extensions #17483

merged 1 commit into from
Aug 29, 2019

Conversation

bricelam
Copy link
Contributor

Part of #17482

@bricelam bricelam added this to the 3.0.0 milestone Aug 28, 2019
@bricelam bricelam requested a review from dougbu as a code owner August 28, 2019 22:28
@bricelam bricelam changed the base branch from release/3.1 to release/3.0 August 28, 2019 22:29
@bricelam
Copy link
Contributor Author

@ajcvickers I wasn't able to make it break, so it may be fine to leave in 3.0.

@ajcvickers
Copy link
Member

@bricelam I think in that case we don't need to do this for ask mode.

@bricelam bricelam removed this from the 3.0.0 milestone Aug 29, 2019
@bricelam bricelam removed the ask-mode label Aug 29, 2019
@bricelam bricelam changed the base branch from release/3.0 to release/3.1 August 29, 2019 15:10
@bricelam bricelam changed the title [release/3.0] Remove System.Threading.Tasks.Extensions Remove System.Threading.Tasks.Extensions Aug 29, 2019
@bricelam bricelam merged commit fdba4f7 into dotnet:release/3.1 Aug 29, 2019
@bricelam bricelam deleted the overvaluedtask branch August 29, 2019 15:12
@ajcvickers ajcvickers mentioned this pull request Aug 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

@smitpatel smitpatel smitpatel approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

@roji roji Awaiting requested review from roji

@dougbu dougbu Awaiting requested review from dougbu dougbu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bricelam @ajcvickers @smitpatel @JunTaoLuo