Fix Migration Batching When Seed Data Has Non-Writable Columns (I.E. RowVersion) #18320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@smitpatel I removed the issue reference. This is certainly an issue, but I'm not sure if it has been reported before. |
smitpatel
reviewed
Oct 10, 2019
| m.KeyValues, | ||
| v => Assert.Equal(45, v)); | ||
| }), | ||
| builderOptions => builderOptions.UseFakeRelational(a => a.MaxBatchSize(4))); |
There was a problem hiding this comment.
Do you really need this option? It should work without it.
There was a problem hiding this comment.
The default batch size in the Relational abstract class is 1. This fails if the batch size setting is not set. The test requires all 4 inserts included in the same batch, but when that option is removed, it becomes 4 operations.
AndriySvyryd
approved these changes
Oct 16, 2019
…://github.com/crowet/EntityFrameworkCore into bugfix/seed-data-non-writable-insert-batching
|
@crowet Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Regression from pull request Seed Data: Exclude concurrency token from Data Operations #13510
Fix migration scripts when seed data has non-writable columns (i.e. rowversion)
Prior to regression, migration scripts would insert seed data in batching.
This fix restores behavior.
https://github.com/aspnet/AspNetCore/wiki/Engineering-guidelines
Review the guidelines for CONTRIBUTING.md for more details.