Apply entity equality to query filters #18426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Oct 17, 2019
src/EFCore/Query/Internal/EntityEqualityRewritingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
roji
force-pushed
the
EntityEqualityInQueryFilter
branch
from
aadfe52
to
1b62405
Compare
smitpatel
reviewed
Oct 17, 2019
src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Oct 17, 2019
src/EFCore/Query/Internal/EntityEqualityRewritingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Oct 17, 2019
src/EFCore/Query/Internal/EntityEqualityRewritingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
roji
force-pushed
the
EntityEqualityInQueryFilter
branch
2 times, most recently
from
3f4d48f
to
61f1097
Compare
smitpatel
reviewed
Oct 17, 2019
src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
approved these changes
Oct 17, 2019
roji
force-pushed
the
EntityEqualityInQueryFilter
branch
from
61f1097
to
6a37d9d
Compare
|
@smitpatel note tiny change to support inheritance scenarios... Am merging as everything is green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18158
Added the entity equality scenario to an existing query filter in Northwind - not super pretty but works. I can do a QueryBugTest instead (extra db), let me know.