Query: Lift projectionMapping always when pushing down SelectExpressi… #18520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on into subuquery Issue: When converting correlation to join, we add the join key columns to projection to make sure they are always available. We had logic that if projection contains any columns then projection mapping is already applied to projection. But in above case that is incorrect. That leaves us with incorrect EntityProjection which fails in further translation as multi-part identifier could not be bound. We should always lift projectionMapping during Pushdown unless projectionMapping is applied which can be checked through type. This scenario does not work for owned/weak types due to #18519 Resolves #18514
smitpatel
force-pushed
the
smit/issue18514
branch
from
49ff287
to
2e9e456
Compare
maumar
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on into subuquery
Issue: When converting correlation to join, we add the join key columns to projection to make sure they are always available.
We had logic that if projection contains any columns then projection mapping is already applied to projection.
But in above case that is incorrect.
That leaves us with incorrect EntityProjection which fails in further translation as multi-part identifier could not be bound.
We should always lift projectionMapping during Pushdown unless projectionMapping is applied which can be checked through type.
This scenario does not work for owned/weak types due to #18519
Resolves #18514