Fix ValueGeneratedOnUpdate in scaffolding #18619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
ScaffoldOnUpdate
branch
2 times, most recently
from
1b86c4a to
4f0f24b
Compare
smitpatel
reviewed
Oct 28, 2019
| @@ -703,28 +703,16 @@ private void GenerateProperty(IProperty property, bool useDataAnnotations) | |||
| if (((IConventionProperty)property).GetValueGeneratedConfigurationSource().HasValue | |||
| && RelationalValueGenerationConvention.GetValueGenerated(property) != valueGenerated) | |||
| { | |||
| string methodName; | |||
| switch (valueGenerated) | |||
| var methodName = valueGenerated switch | |||
There was a problem hiding this comment.
Any reason here? We agreed to use it except for complex situations, and this seems as simple as it gets. If we don't use it here we basically don't use it anywhere, no?
There was a problem hiding this comment.
3 line ternary as a return of one of the statement. That is complex enough.
There was a problem hiding this comment.
This is not how I understand the decision made by the team, and basically invalidates the use of this construct for the vast majority of cases. This isn't extremely important but maybe another opinion would help clarify.
There was a problem hiding this comment.
Seems fine to me. Still readable.
smitpatel
reviewed
Oct 28, 2019
src/EFCore.Design/Scaffolding/Internal/CSharpDbContextGenerator.cs
Outdated
Show resolved
Hide resolved
And add some tests. Fixes #18579
roji
force-pushed
the
ScaffoldOnUpdate
branch
from
4f0f24b to
aa39b32
Compare
ajcvickers
approved these changes
Oct 29, 2019
|
/cc @Pilchie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add some tests.
Fixes #18579