Ignore line endings in test assertions #18674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
/cc @Pilchie |
smitpatel
approved these changes
Oct 31, 2019
|
A wild guess! |
|
Good guess, makes sense to me... There are a few more cases like this, will be amending this PR a bit. |
roji
force-pushed
the
TestLineEndings
branch
2 times, most recently
from
4d022e5
to
fe10323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test failures triggered in EFCore.PG (tests are not overridden). Not sure why this doesn't happen on our CI but it doesn't really matter much...