Add back execution retry for query. #18691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Pilchie |
AndriySvyryd
force-pushed
the
Issue18628
branch
4 times, most recently
from
31476fe
to
92808a3
Compare
ajcvickers
approved these changes
Nov 1, 2019
smitpatel
reviewed
Nov 1, 2019
| } | ||
|
|
||
| public ReaderColumn[] ProjectionColumns { get; } |
There was a problem hiding this comment.
entry method into visitor with out parameter
smitpatel
reviewed
Nov 1, 2019
| if (ProjectionColumns != null) | ||
| { | ||
| var columnType = valueExpression.Type; | ||
| if (!columnType.IsValueType |
There was a problem hiding this comment.
For non value type you wouldn't need casting to object, It should just work
There was a problem hiding this comment.
I need it to compile to Func<DbDatareader, int[], object>
AndriySvyryd
force-pushed
the
Issue18628
branch
from
92808a3
to
3ca6af9
Compare
Move the retry scope for SaveChanges to properly reset the state before retrying. Fixes #18628
AndriySvyryd
force-pushed
the
Issue18628
branch
from
3ca6af9
to
70c8988
Compare
roji
added a commit
to roji/efcore.pg
that referenced
this pull request
Feb 3, 2020
Includes test changes done in dotnet/efcore#18691 Tests now run using retrying strategy, hopefully working around the transient exceptions we're seeing on CI since the migration tests. Closes npgsql#1244
roji
added a commit
to npgsql/efcore.pg
that referenced
this pull request
Feb 3, 2020
Includes test changes done in dotnet/efcore#18691 Tests now run using retrying strategy, hopefully working around the transient exceptions we're seeing on CI since the migration tests. Closes #1244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
We lacked tests for implicit usage of the execution strategy, so when the query pipeline was rewritten the lack of this feature wasn't detected.
Solution:
Add execution retry for query with a buffering data reader.
Move the retry scope for SaveChanges to properly reset the state before retrying.
Add tests for implicit usage of the execution strategy.
Fixes #18628