Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY out query translation failure in tests #18964

Merged
merged 1 commit into from
Dec 4, 2019
Merged

DRY out query translation failure in tests #18964

merged 1 commit into from
Dec 4, 2019

Conversation

roji
Copy link
Member

@roji roji commented Nov 17, 2019

No description provided.

@roji roji requested a review from maumar November 17, 2019 19:46
@maumar
Copy link
Contributor

maumar commented Nov 18, 2019

We have a method AssertTranslationFailed - we should DRY/combine those. Perhaps move to query test base?

@roji roji force-pushed the AssertTranslationFailure branch from 304f7e8 to 802011c Compare November 19, 2019 02:48
@roji
Copy link
Member Author

roji commented Nov 19, 2019

New version up.

@roji roji force-pushed the AssertTranslationFailure branch from 802011c to 1eea0d5 Compare November 19, 2019 03:38
@roji roji force-pushed the AssertTranslationFailure branch from 1eea0d5 to 57f2d22 Compare December 4, 2019 13:52
@roji roji merged commit fb0a1d8 into master Dec 4, 2019
@roji roji deleted the AssertTranslationFailure branch December 4, 2019 16:01
@ajcvickers ajcvickers mentioned this pull request Dec 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel left review comments

@maumar maumar maumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roji @maumar @smitpatel