Re-introduction of GeneratePseudoFromClause for specific "empty" FROM clauses #18999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be done in master as part of #18923 |
|
I see that for 5.0. No chance for this particular one for 3.1?
|
|
@cincuranet 3.1 is already finalized, so the change cannot go there. Also, we are not allowed to make API changes in patch releases, except for very exceptional circumstances--i.e. security. So, unfortunately this means that the next release this change can be in is 5.0. |
|
OK. I will work around it on my side then.
|
smitpatel
approved these changes
Nov 25, 2019
|
@cincuranet Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #18926.
It would really really really help [1] if this would be considered for merge 🙏 and before 3.1 ships 🤞. I don't see any breaking changes here, because in 3.0 this was non-existing and hence nobody could override, hence nothing is/was/will be broken.
[1]: It would help because copying
VisitSelectand duplicating all the code is impractical because of some private methods usage and also makes no sense when simple plug in point can handle it.