Seal private nested classes to avoid unneeded virtual methods #19081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
requested review from
AndriySvyryd,
smitpatel,
maumar,
roji and
bricelam
| @@ -41,7 +41,7 @@ public virtual Expression Process(Expression query) | |||
| } | |||
|
|
|||
| // TODO: For debugging | |||
| private class EnumerableVerifyingExpressionVisitor : ExpressionVisitor | |||
| private sealed class EnumerableVerifyingExpressionVisitor : ExpressionVisitor | |||
There was a problem hiding this comment.
@smitpatel Do you remember what this comment means and whether it is still relevant?
There was a problem hiding this comment.
We can remove this class. It was to make sure we don't have enumerable methods where queryable should be there. But I believe exception from here won't be useful either way.
AndriySvyryd
approved these changes
Nov 26, 2019
Fixes #19066 Also removed `GetTypeInfo` when it is not needed
ajcvickers
force-pushed
the
SealYourPrivates1125
branch
from
f72f32e
to
b397712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19066
Also removed
GetTypeInfowhen it is not needed