[3.1.1] Set ordinal key values for embedded owned collection entities #19100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue18948
branch
from
4e3d09d to
1eeb280
Compare
|
Moving the key modification detection logic turned out to require more changes than I initially though, so filed #19135 to consider it later. |
AndriySvyryd
force-pushed
the
Issue18948
branch
from
1eeb280 to
0aa874d
Compare
ajcvickers
reviewed
Dec 3, 2019
ajcvickers
reviewed
Dec 3, 2019
Consistently allow readonly properties to be set the current store values during SaveChanges to allow propagation of the new values. Fixes #18948
AndriySvyryd
force-pushed
the
Issue18948
branch
from
0aa874d to
c2921e0
Compare
ajcvickers
approved these changes
Dec 4, 2019
|
Will this go in 3.1.1 or 3.1.2? |
|
@smitpatel If Tactics approves, then it will go in 3.1.2. (3.1.1 is closed down now.) |
AndriySvyryd
changed the title
|
Closed 3.1.1 milestone. |
ajcvickers
changed the title
|
@AndriySvyryd This is approved for 3.1.1 servicing. Please merge ASAP. |
|
Approved for 3.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18948
Description
Cosmos provider allows to save collections of owned entities as embedded documents in a JSON array property in the owner document without storing the key values explicitly. They are synthesized from the owner key and the ordinal in the collection. However we didn't synthesize the values when saving the entities, only when querying.
The fix is to synthesize the key values when saving the entities. And also consistently allow readonly properties to be set the current store values during SaveChanges to allow propagation of the new values.
Customer Impact
The bug leads to the newly saved entities having a different identity and causes duplication in the owned collections if queried after saving a new entity using the same context.
How found
Customer-reported
Test coverage
We did not have tests querying back the entities that were just saved using the same context.
Regression?
No
Risk
Low, only affects the Cosmos provider