-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit order (#19216) #19217
Explicit order (#19216) #19217
Conversation
This broke cosmos tests. Build is broken! |
Oh shoot, I'm guessing the Cosmos tests don't run on PRs? I'll take a look at this a later today (or first thing tomorrow morning, European time). We should discuss if this is a good situation CI-wise... |
@roji I have a bit of time available now, so I'll send something out to fix the build.
We have been discussing this, and @AndriySvyryd spent considerable effort trying to get them to run reliably, with very little luck. |
We wouldn't run Cosmos tests on fork PRs anyway due to security concerns. |
And still no way to get the emulator onto the image somehow? How about trying to install it as part of the build itself? I know it sounds weird but it's commonly done at least in Linux CI scripts. |
Oh, and thanks for the help @ajcvickers |
Does it imply that any external PR which can affect Cosmos build has to be verified locally before merging too? |
@smitpatel @AndriySvyryd @roji Let's discuss this on an internal channel. |
Fixes #19216.