Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit order (#19216) #19217

Merged
merged 1 commit into from
Dec 7, 2019
Merged

Explicit order (#19216) #19217

merged 1 commit into from
Dec 7, 2019

Conversation

cincuranet
Copy link
Contributor

Fixes #19216.

@roji roji merged commit f765b9d into dotnet:master Dec 7, 2019
@smitpatel
Copy link
Contributor

This broke cosmos tests. Build is broken!

@cincuranet
Copy link
Contributor Author

It's green in ADO.
img

@roji
Copy link
Member

roji commented Dec 8, 2019

Oh shoot, I'm guessing the Cosmos tests don't run on PRs? I'll take a look at this a later today (or first thing tomorrow morning, European time).

We should discuss if this is a good situation CI-wise...

@ajcvickers
Copy link
Member

@roji I have a bit of time available now, so I'll send something out to fix the build.

We should discuss if this is a good situation CI-wise...

We have been discussing this, and @AndriySvyryd spent considerable effort trying to get them to run reliably, with very little luck.

@AndriySvyryd
Copy link
Member

We wouldn't run Cosmos tests on fork PRs anyway due to security concerns.

@roji
Copy link
Member

roji commented Dec 8, 2019

And still no way to get the emulator onto the image somehow? How about trying to install it as part of the build itself? I know it sounds weird but it's commonly done at least in Linux CI scripts.

@roji
Copy link
Member

roji commented Dec 8, 2019

Oh, and thanks for the help @ajcvickers

@smitpatel
Copy link
Contributor

We wouldn't run Cosmos tests on fork PRs anyway due to security concerns.

Does it imply that any external PR which can affect Cosmos build has to be verified locally before merging too?

@ajcvickers
Copy link
Member

@smitpatel @AndriySvyryd @roji Let's discuss this on an internal channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projection_of_entity_type_into_object_list is missing order
5 participants