Multitarget extensions packages to remove dependencies for source build #2090

JunTaoLuo · 2019-07-26T23:03:29Z

Addresses #2056

JunTaoLuo · 2019-07-27T04:26:56Z

FYI not ready for review, ~~FileProviders.Embedded has msbuild props/targets that need to be added for netcoreapp3.0~~ actually it should still work, I'll test it to be sure.

src/FileProviders/Embedded/src/Microsoft.Extensions.FileProviders.Embedded.csproj

JunTaoLuo · 2019-08-06T03:39:58Z

@anurse who would be a good candidate to review this? The main change is to multitarget some of the packages built for source build with netcoreapp3.0 and remove dependencies. However there are a few areas that needed some changes:

The packaging of FilesProviders.Embedded had to be changed since the TFMs we target is conditional
For the projects where we are adding the netcoreapp3.0 tfm, I also made sure the tests test both the netcoreapp3.0 and netstandard 2.0 binaries. Luckily most tests already test on netcoreapp3.0 and net472 so the coverage is mostly sufficient. However, I guess we might also want to test on netcoreapp2.2 to ensure we are testing netstandard2.0 binaries in Core. Do you think that would be useful?
I had to update the test logic in Config.UserSecrets to accommodate more tfm for test coverage.

src/Configuration/Config.UserSecrets/test/MsBuildTargetTest.cs

JunTaoLuo · 2019-08-06T19:10:15Z

cc @pranavkm @ajaybhargavb to take a look at FileProviders changes
cc @HaoK for Config changes
cc @BrennanConroy for Logging changes
cc @Tratcher for Hosting changes
cc @rynowak @anurse for everything

Tratcher

for Hosting

BrennanConroy

for logging

...guration/Config.UserSecrets/test/Microsoft.Extensions.Configuration.UserSecrets.Tests.csproj

HaoK

Config looks good assuming the net472 change to user secrets is expected

...guration/Config.UserSecrets/test/Microsoft.Extensions.Configuration.UserSecrets.Tests.csproj

pranavkm · 2019-08-06T22:22:03Z

src/Caching/Abstractions/ref/Microsoft.Extensions.Caching.Abstractions.csproj

@@ -1,10 +1,14 @@
 <!-- This file is automatically generated. -->
 <Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
-    <TargetFrameworks>netstandard2.0</TargetFrameworks>
+    <TargetFrameworks>netstandard2.0;netcoreapp3.0</TargetFrameworks>


Spoke to @JunTaoLuo offline. We need to make sure this TFM works when we're source building netcoreapp3.1. I'd personally prefer not to cross-compile 3 different TFMs just for source build.

I spoke with @crummel, turns out they are tracking it in dotnet/source-build#759. Which is currently triaged for 3.1.

dougbu

I suspect this is fine but please fill in the details about ref/ projects

src/Caching/Abstractions/ref/Microsoft.Extensions.Caching.Abstractions.csproj

src/Configuration/Config.Json/src/Microsoft.Extensions.Configuration.Json.csproj

JunTaoLuo · 2019-08-07T20:25:53Z

I don't see an appropriate label but this has been approved by shiproom.

…ld (dotnet/extensions#2090) \n\nCommit migrated from dotnet/extensions@3ec8c35

…ld (dotnet/extensions#2090) Commit migrated from dotnet/extensions@3ec8c35

…ld (dotnet/extensions#2090) \n\nCommit migrated from dotnet/extensions@3ec8c35

JunTaoLuo requested a review from analogrelay July 26, 2019 23:03

JunTaoLuo requested a review from Tratcher as a code owner July 26, 2019 23:03

Tratcher approved these changes Jul 26, 2019

View reviewed changes

JunTaoLuo force-pushed the johluo/multitarget branch from bf2c431 to 65575d0 Compare July 27, 2019 02:49

JunTaoLuo commented Jul 27, 2019

View reviewed changes

src/FileProviders/Embedded/src/Microsoft.Extensions.FileProviders.Embedded.csproj Show resolved Hide resolved

Pilchie added the area-infrastructure label Jul 29, 2019

JunTaoLuo force-pushed the johluo/multitarget branch from 65575d0 to cbbe6a8 Compare August 5, 2019 06:25

John Luo added 4 commits August 5, 2019 17:44

Multitarget extensions packages to remove dependencies for source build

0a6cceb

Wip

b9e3c0b

Update ref assemblies

d3d2c3a

Update nuspec logic

4dfa69d

JunTaoLuo force-pushed the johluo/multitarget branch from cbbe6a8 to 4dfa69d Compare August 6, 2019 00:44

JunTaoLuo changed the base branch from master to release/3.0 August 6, 2019 00:44

John Luo added 3 commits August 5, 2019 19:26

Make sure we test for both tfms

e978d39

Try netcoreapp2.2

311cdf9

Fix bug in source buid nupkg

7d2d9f1

JunTaoLuo commented Aug 6, 2019

View reviewed changes

src/Configuration/Config.UserSecrets/test/MsBuildTargetTest.cs Outdated Show resolved Hide resolved

Fix

d65b866

JunTaoLuo requested review from ajaybhargavb, BrennanConroy, pranavkm and rynowak August 6, 2019 19:10

davidfowl mentioned this pull request Aug 6, 2019

Update DI and Hosting to use Microsoft.Bcl.AsyncInterfaces #2137

Merged

Tratcher self-requested a review August 6, 2019 20:01

Tratcher approved these changes Aug 6, 2019

View reviewed changes

BrennanConroy approved these changes Aug 6, 2019

View reviewed changes

HaoK reviewed Aug 6, 2019

View reviewed changes

...guration/Config.UserSecrets/test/Microsoft.Extensions.Configuration.UserSecrets.Tests.csproj Outdated Show resolved Hide resolved

HaoK reviewed Aug 6, 2019

View reviewed changes

...guration/Config.UserSecrets/test/Microsoft.Extensions.Configuration.UserSecrets.Tests.csproj Show resolved Hide resolved

HaoK approved these changes Aug 6, 2019

View reviewed changes

Feedback

44ff6b5

pranavkm reviewed Aug 6, 2019

View reviewed changes

dougbu reviewed Aug 6, 2019

View reviewed changes

src/Caching/Abstractions/ref/Microsoft.Extensions.Caching.Abstractions.csproj Show resolved Hide resolved

src/Configuration/Config.Json/src/Microsoft.Extensions.Configuration.Json.csproj Show resolved Hide resolved

JunTaoLuo mentioned this pull request Aug 7, 2019

Multitarget packages to remove dependencies for source build dotnet/aspnetcore#12936

Merged

pranavkm approved these changes Aug 7, 2019

View reviewed changes

JunTaoLuo added accepted and removed accepted labels Aug 7, 2019

JunTaoLuo merged commit 3ec8c35 into release/3.0 Aug 7, 2019

ghost deleted the johluo/multitarget branch August 7, 2019 20:26

JunTaoLuo mentioned this pull request Aug 7, 2019

Fix build break by using API that's available across net472 and netcoreapp3.0 #2157

Merged

JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 12, 2020

Multitarget extensions packages to remove dependencies for source bui…

53b17fb

…ld (dotnet/extensions#2090) \n\nCommit migrated from dotnet/extensions@3ec8c35

JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 15, 2020

Multitarget extensions packages to remove dependencies for source bui…

95746c5

…ld (dotnet/extensions#2090) \n\nCommit migrated from dotnet/extensions@3ec8c35

maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Feb 28, 2020

Multitarget extensions packages to remove dependencies for source bui…

363f994

…ld (dotnet/extensions#2090) Commit migrated from dotnet/extensions@3ec8c35

maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 2, 2020

Multitarget extensions packages to remove dependencies for source bui…

49c6f0a

…ld (dotnet/extensions#2090) Commit migrated from dotnet/extensions@3ec8c35

maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020

Multitarget extensions packages to remove dependencies for source bui…

accaa12

…ld (dotnet/extensions#2090) Commit migrated from dotnet/extensions@3ec8c35

maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020

Multitarget extensions packages to remove dependencies for source bui…

53432bd

…ld (dotnet/extensions#2090) Commit migrated from dotnet/extensions@3ec8c35

maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 27, 2020

Multitarget extensions packages to remove dependencies for source bui…

71a7972

…ld (dotnet/extensions#2090) Commit migrated from dotnet/extensions@3ec8c35

JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Nov 17, 2020

Multitarget extensions packages to remove dependencies for source bui…

90d689a

…ld (dotnet/extensions#2090) \n\nCommit migrated from dotnet/extensions@3ec8c35

ghost locked as resolved and limited conversation to collaborators May 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multitarget extensions packages to remove dependencies for source build #2090

Multitarget extensions packages to remove dependencies for source build #2090

JunTaoLuo commented Jul 26, 2019

JunTaoLuo commented Jul 27, 2019 •

edited

Loading

JunTaoLuo commented Aug 6, 2019

JunTaoLuo commented Aug 6, 2019 •

edited

Loading

Tratcher left a comment

BrennanConroy left a comment

HaoK left a comment

pranavkm Aug 6, 2019

JunTaoLuo Aug 7, 2019

dougbu left a comment

JunTaoLuo commented Aug 7, 2019

Multitarget extensions packages to remove dependencies for source build #2090

Multitarget extensions packages to remove dependencies for source build #2090

Conversation

JunTaoLuo commented Jul 26, 2019

JunTaoLuo commented Jul 27, 2019 • edited Loading

JunTaoLuo commented Aug 6, 2019

JunTaoLuo commented Aug 6, 2019 • edited Loading

Tratcher left a comment

Choose a reason for hiding this comment

BrennanConroy left a comment

Choose a reason for hiding this comment

HaoK left a comment

Choose a reason for hiding this comment

pranavkm Aug 6, 2019

Choose a reason for hiding this comment

JunTaoLuo Aug 7, 2019

Choose a reason for hiding this comment

dougbu left a comment

Choose a reason for hiding this comment

JunTaoLuo commented Aug 7, 2019

JunTaoLuo commented Jul 27, 2019 •

edited

Loading

JunTaoLuo commented Aug 6, 2019 •

edited

Loading