Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Commit 7d5188b

Browse files
committed
Add back public api
1 parent 668f574 commit 7d5188b

File tree

3 files changed

+21
-5
lines changed

3 files changed

+21
-5
lines changed

src/Microsoft.AspNetCore.Http/Features/ResponseCookiesFeature.cs

+14-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,19 @@ public class ResponseCookiesFeature : IResponseCookiesFeature
2424
/// <see cref="IResponseCookiesFeature"/> and the <see cref="IHttpResponseFeature"/>.
2525
/// </param>
2626
public ResponseCookiesFeature(IFeatureCollection features)
27+
: this(features, builderPool: null)
28+
{
29+
}
30+
31+
/// <summary>
32+
/// Initializes a new <see cref="ResponseCookiesFeature"/> instance.
33+
/// </summary>
34+
/// <param name="features">
35+
/// <see cref="IFeatureCollection"/> containing all defined features, including this
36+
/// <see cref="IResponseCookiesFeature"/> and the <see cref="IHttpResponseFeature"/>.
37+
/// </param>
38+
/// <param name="builderPool">The <see cref="ObjectPool{T}"/>, if available.</param>
39+
public ResponseCookiesFeature(IFeatureCollection features, ObjectPool<StringBuilder> builderPool)
2740
{
2841
if (features == null)
2942
{
@@ -43,7 +56,7 @@ public IResponseCookies Cookies
4356
if (_cookiesCollection == null)
4457
{
4558
var headers = HttpResponseFeature.Headers;
46-
_cookiesCollection = new ResponseCookies(headers);
59+
_cookiesCollection = new ResponseCookies(headers, null);
4760
}
4861

4962
return _cookiesCollection;

src/Microsoft.AspNetCore.Http/Internal/ResponseCookies.cs

+4-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33

44
using System;
55
using System.Collections.Generic;
6+
using System.Text;
7+
using Microsoft.Extensions.ObjectPool;
68
using Microsoft.Extensions.Primitives;
79
using Microsoft.Net.Http.Headers;
810

@@ -17,7 +19,8 @@ public class ResponseCookies : IResponseCookies
1719
/// Create a new wrapper.
1820
/// </summary>
1921
/// <param name="headers">The <see cref="IHeaderDictionary"/> for the response.</param>
20-
public ResponseCookies(IHeaderDictionary headers)
22+
/// <param name="builderPool">The <see cref="ObjectPool{T}"/>, if available.</param>
23+
public ResponseCookies(IHeaderDictionary headers, ObjectPool<StringBuilder> builderPool)
2124
{
2225
if (headers == null)
2326
{

test/Microsoft.AspNetCore.Http.Tests/ResponseCookiesTest.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class ResponseCookiesTest
1515
public void DeleteCookieShouldSetDefaultPath()
1616
{
1717
var headers = new HeaderDictionary();
18-
var cookies = new ResponseCookies(headers);
18+
var cookies = new ResponseCookies(headers, null);
1919
var testcookie = "TestCookie";
2020

2121
cookies.Delete(testcookie);
@@ -31,7 +31,7 @@ public void DeleteCookieShouldSetDefaultPath()
3131
public void NoParamsDeleteRemovesCookieCreatedByAdd()
3232
{
3333
var headers = new HeaderDictionary();
34-
var cookies = new ResponseCookies(headers);
34+
var cookies = new ResponseCookies(headers, null);
3535
var testcookie = "TestCookie";
3636

3737
cookies.Append(testcookie, testcookie);
@@ -70,7 +70,7 @@ public void EscapesKeyValuesBeforeSettingCookie(
7070
string expected)
7171
{
7272
var headers = new HeaderDictionary();
73-
var cookies = new ResponseCookies(headers);
73+
var cookies = new ResponseCookies(headers, null);
7474

7575
cookies.Append(key, value);
7676

0 commit comments

Comments
 (0)