Skip to content
This repository has been archived by the owner on Mar 19, 2019. It is now read-only.

[Announcement] WebListener packages and APIs merged and renamed #289

Closed
Tratcher opened this issue Jan 4, 2017 · 13 comments
Closed

[Announcement] WebListener packages and APIs merged and renamed #289

Tratcher opened this issue Jan 4, 2017 · 13 comments
Milestone

Comments

@Tratcher
Copy link
Member

Tratcher commented Jan 4, 2017

The packages Microsoft.AspNetCore.Server.WebListener and Microsoft.Net.Http.Server have been merged into a new package Microsoft.AspNetCore.Server.HttpSys. The namespaces have been updated to match.

The WebHostBuilder extension has similarly been renamed from UseWebListener to UseHttpSys. The options for this extension have been flattened as shown here.

The low level WebListener API has been removed to avoid duplication and confusion with HttpListener which has recently been added to .NET Core.

A few more consolidations and optimizations will follow, as discussed here: #283. The discussion issue will be updated accordingly with any additional breaking changes.

@scottaddie
Copy link
Member

Will this repo be renamed to "HttpSys" as well?

@Tratcher
Copy link
Member Author

Tratcher commented Jan 4, 2017

Not right now. We'll continue to use WebListener as the project codename.

@davidfowl
Copy link
Member

We should probably rename the repository as well /cc @Eilon

@Tratcher
Copy link
Member Author

Tratcher commented Jan 5, 2017

Just don't name it flat HttpSys, that would be too confusing. HttpSysIntegratoin like IISIntegration?

@Eilon
Copy link
Member

Eilon commented Jan 5, 2017

Let me know and I'll rename it... GitHub will auto-redirect everything so it's quite safe.

@davidfowl
Copy link
Member

Just don't name it flat HttpSys, that would be too confusing. HttpSysIntegratoin like IISIntegration?

Why not? https://github.com/tjanczuk/httpsys 😄

HttpSysIntegration is fine.

@Eilon
Copy link
Member

Eilon commented Jan 5, 2017

Let's get confirmation from @DamianEdwards and I'll rename.

@Tratcher
Copy link
Member Author

Tratcher commented Jan 5, 2017

Is HttpSysServer any better? It mirrors KestrelHttpServer.

@davidfowl
Copy link
Member

I like it better

@DamianEdwards
Copy link
Member

HttpSysServer

@Eilon
Copy link
Member

Eilon commented Jan 5, 2017

DONE.

@Tratcher
Copy link
Member Author

Tratcher commented Jan 5, 2017

One additional change: Direct WebSocket support has been removed from this new package. The application must now add the WebSocket middleware for WebSocket support. This mirrors the Kestrel architecture. There should not be any functional changes because the two components were previously sharing the same implementation code.

See https://github.com/aspnet/WebSockets/blob/b996ee39a429479e0bc301d198007cd85cc2acbd/samples/EchoApp/Startup.cs#L34 and the Microsoft.AspNetCore.WebSockets package.

@muratg
Copy link

muratg commented May 12, 2017

We are closing this issue because no further action is planned for this issue. If you still have any issues or questions, please log a new issue with any additional details that you have.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants