Skip to content
This repository has been archived by the owner on Nov 1, 2018. It is now read-only.

Grant requestTimeout for InProcess scenario #555

Closed
pan-wang opened this issue Jan 25, 2018 · 5 comments
Closed

Grant requestTimeout for InProcess scenario #555

pan-wang opened this issue Jan 25, 2018 · 5 comments

Comments

@pan-wang
Copy link
Contributor

For OutOfProcess case, ANCM grants the requestTimeout in configuration by setting WinHttp connection timeouts. For InProcess, we grant this timeout setting by flowing it to the managed layer.

@muratg muratg added this to the 2.1.0-preview2 milestone Feb 5, 2018
@muratg
Copy link
Contributor

muratg commented Feb 5, 2018

@jkotalik will sync up with @Tratcher on this regarding http.sys features around this. That may mitigate the need for this one. Tentatively putting this in preview2, but we may move it out.

@Tratcher
Copy link
Member

Tratcher commented Feb 5, 2018

Http.Sys has no matching feature. It has request header parsing timeouts and body rate limiting, but there's no timeout on application request processing like ANCM had.

@muratg muratg removed the 1 - Ready label Feb 5, 2018
@muratg
Copy link
Contributor

muratg commented Feb 5, 2018

@Tratcher I think this was about header parsing timeout.

@Tratcher
Copy link
Member

Tratcher commented Feb 5, 2018

No, https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/aspnet-core-module.

Specifies the duration for which the ASP.NET Core Module will wait for a response from the process listening on %ASPNETCORE_PORT%.

The in-proc corollary is waiting for the application to process the request.

@muratg
Copy link
Contributor

muratg commented Feb 12, 2018

Per triage, we won't be doing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants