Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

XML doc issues in Identity classes #875

Closed
SteveSandersonMS opened this issue Jun 16, 2016 · 3 comments
Closed

XML doc issues in Identity classes #875

SteveSandersonMS opened this issue Jun 16, 2016 · 3 comments
Assignees
@HaoK
Labels
3 - Done bug
Milestone
1.1.0-preview1

Comments

@SteveSandersonMS
Copy link
Member

  • LockoutOptions.AllowedForNewUsers property gives no intellisense documentation (whereas the other two properties on that class do)
  • CookieAuthenticationOptions.CookieName intellisense docs claims the default value is .AspNetCore.Cookies, but the actual default value seems to be .AspNetCore.Identity.Application
@HaoK
Copy link
Member

HaoK commented Jun 16, 2016

This is because the default from identity is different than the cookies default but the intellesense comes from cookies

CookieAuthenticationOptions.CookieName intellisense docs claims the default value is .AspNetCore.Cookies, but the actual default value seems to be .AspNetCore.Identity.Application

@SteveSandersonMS
Copy link
Member Author

OK, makes sense. Maybe we shouldn't mention the default value in the XML docs if we have a high probability of giving false information.

@HaoK HaoK self-assigned this Jul 1, 2016
@HaoK HaoK added this to the 1.0.1 milestone Jul 1, 2016
@HaoK HaoK added the bug label Jul 1, 2016
@HaoK
Copy link
Member

HaoK commented Jul 11, 2016

ec4c08d

@HaoK HaoK closed this as completed Jul 11, 2016
@HaoK HaoK added the 3 - Done label Jul 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HaoK HaoK

Labels
3 - Done bug
Projects
None yet
Milestone
1.1.0-preview1
Development

No branches or pull requests
2 participants
@SteveSandersonMS @HaoK