Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Primary headers #1482

Closed
benaadams opened this issue Mar 11, 2017 · 5 comments
Closed

Primary headers #1482

benaadams opened this issue Mar 11, 2017 · 5 comments
Assignees
@natemcmaster
Labels
3 - Done enhancement
Milestone
2.0.0-preview1

Comments

@benaadams
Copy link
Contributor

Add Accept and Connection the Request primary headers
@davidfowl
Copy link
Member

Agreed, surprised they weren't to begin with. Why is that?

@benaadams
Copy link
Contributor Author

They weren't plaintext headers :)

@muratg muratg added this to the 2.0.0 milestone Mar 20, 2017
@natemcmaster
Copy link
Contributor

I must be missing something....isn't Accept already a primary request header?

KestrelHttpServer/tools/CodeGenerator/KnownHeaders.cs

Line 130 in 200d8de

"Accept",

@benaadams
Copy link
Contributor Author

Ok, just connection then :)

@cesarblum
Copy link
Contributor

cesarblum commented Mar 29, 2017 •
edited
Loading

That nasty blank line there was just waiting to have Connection inserted in it.

@natemcmaster natemcmaster mentioned this issue Mar 29, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@natemcmaster natemcmaster

Labels
3 - Done enhancement
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
5 participants
@davidfowl @cesarblum @benaadams @muratg @natemcmaster