Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

StringValues should always be passed as in (and a readonly struct) #2301

Closed
benaadams opened this issue Feb 7, 2018 · 1 comment
Closed

StringValues should always be passed as in (and a readonly struct) #2301

benaadams opened this issue Feb 7, 2018 · 1 comment
Milestone
Backlog

Comments

@benaadams
Copy link
Contributor

This makes it more efficient by skipping the copy before passing it by reference; which is what happens with pass by value.

However it should also be marked as a readonly struct dotnet/aspnetcore#2856
@benaadams benaadams mentioned this issue Feb 7, 2018
Merged
@muratg muratg added this to the 2.1.0-preview2 milestone Feb 21, 2018
@muratg
Copy link
Contributor

muratg commented Feb 21, 2018

(Assigning to @halter73 who's already reviewing the PR)

@muratg muratg modified the milestones: 2.1.0-preview2, Backlog Feb 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@halter73 @benaadams @muratg