Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Add HeaderCompleteTimeout parameter #483

Closed
benaadams opened this issue Dec 14, 2015 · 5 comments
Closed

Add HeaderCompleteTimeout parameter #483

benaadams opened this issue Dec 14, 2015 · 5 comments

Comments

@benaadams
Copy link
Contributor

Time in which from the header preamble starts it must be completed. If exceeded the client is determined to be disconnected and the request aborted.

Failure state: 408 Request Timeout

"The client did not produce a request within the time that the server was prepared to wait. The client MAY repeat the request without modifications at any later time."

ngnix default client_header_timeout 60s

Implementation-wise the timer can use the same timer as Keep-alive; as a multi stage/state timer.

When deployed in recommended configuration with a reverse proxy (e.g. IIS/nginx) this would be handled by the proxy - however, this wouldn't apply in a pure Kestrel deployment.

@benaadams
Copy link
Contributor Author

@halter73 @DamianEdwards this still RC2? Will finish in next couple days if so.

@DamianEdwards
Copy link
Member

We'll be in beginning of our ASK mode by then, which is very high bar. Late features like this don't meet the bar at this stage I'm afraid.

@benaadams
Copy link
Contributor Author

Is ok - is handled by reverse poxies in suggested deployment, is just marked RC2 still rather than backlog

@benaadams
Copy link
Contributor Author

Also its not a very simple change, so I wouldn't put it in RC2 at this time :)

@muratg muratg modified the milestones: Backlog, 1.0.0-rc2 Mar 14, 2016
@muratg
Copy link
Contributor

muratg commented Jul 25, 2016

This will be covered

@muratg muratg closed this as completed Jul 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants