Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Shrink the size of memory pools when usage decreases #609

Closed
halter73 opened this issue Feb 1, 2016 · 3 comments
Closed

Shrink the size of memory pools when usage decreases #609

halter73 opened this issue Feb 1, 2016 · 3 comments

Comments

@halter73
Copy link
Member

halter73 commented Feb 1, 2016

Currently the memory pool implementation will only grow in size. This means if there is burst of high load that subsided, memory usage for the Kestrel process will not decrease as much as it could.

@halter73 halter73 added the stress label Feb 1, 2016
@benaadams
Copy link
Contributor

Apply common server/cluster load balancing model?

Pools per slab, round robin rents from available slabs till available block? Move slabs move out of rotation; but accept returns. When all blocks are returned dispose slab; if alloc is needed prior, move slab back into rotation; if no slabs being deallocated allocate new.

@benaadams
Copy link
Contributor

Probably need some heuristics on whether growing, shrinking or static to determine whether to take slabs out of rotation

@muratg muratg added this to the 1.0.0-rc2 milestone Feb 23, 2016
@muratg muratg modified the milestones: 1.0.0, 1.0.0-rc2 Mar 14, 2016
@muratg muratg modified the milestones: 1.0.1, 1.0.0 May 18, 2016
@muratg muratg modified the milestones: 1.0.0, 1.0.1 May 31, 2016
@muratg muratg modified the milestones: Backlog, 1.1.0 Jul 8, 2016
@muratg
Copy link
Contributor

muratg commented Nov 21, 2016

Closing because @davidfowl thinks this is not problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants