Revise LogLevel Enum

Author: BrennanConroy

src/Microsoft.Extensions.Logging.Abstractions/LogLevel.cs

@@ -12,40 +12,40 @@ public enum LogLevel
         /// Logs that contain the most detailed messages. These messages may contain sensitive application data.
         /// These messages are disabled by default and should never be enabled in a production environment.
         /// </summary>
-        Trace = 1,
+        Trace = 0,
 
         /// <summary>
         /// Logs that are used for interactive investigation during development.  These logs should primarily contain
         /// information useful for debugging and have no long-term value.
         /// </summary>
-        Debug = 2,
+        Debug = 1,
 
         /// <summary>
         /// Logs that track the general flow of the application. These logs should have long-term value.
         /// </summary>
-        Information = 3,
+        Information = 2,
 
         /// <summary>
         /// Logs that highlight an abnormal or unexpected event in the application flow, but do not otherwise cause the
         /// application execution to stop.
         /// </summary>
-        Warning = 4,
+        Warning = 3,
 
         /// <summary>
         /// Logs that highlight when the current flow of execution is stopped due to a failure. These should indicate a
         /// failure in the current activity, not an application-wide failure.
         /// </summary>
-        Error = 5,
+        Error = 4,
 
         /// <summary>
         /// Logs that describe an unrecoverable application or system crash, or a catastrophic failure that requires
         /// immediate attention.
         /// </summary>
-        Critical = 6,
+        Critical = 5,
 
         /// <summary>
         /// Not used for writing log messages. Specifies that a logging category should not write any messages.
         /// </summary>
-        None = int.MaxValue,
+        None = 6,
     }
 }

test/Microsoft.Extensions.Logging.Test/LogLevelEnumTest.cs

@@ -11,17 +11,17 @@ namespace Microsoft.Extensions.Logging.Test
     public class LogLevelEnumTest
     {
         [Fact]
-        public static void EnumStartsAtOne()
+        public static void EnumStartsAtZero()
         {
-            Assert.Equal(1, GetEnumValues().Min());
+            Assert.Equal(0, GetEnumValues().Min());
         }
 
         [Fact]
         public static void EnumValuesAreUniqueAndConsecutive()
         {
             var values = GetEnumValues();
             values.Sort();
-            Assert.Equal(new[] { 1, 2, 3, 4, 5, 6, int.MaxValue}, values);
+            Assert.Equal(new[] { 0, 1, 2, 3, 4, 5, 6 }, values);
         }
 
         private static List<int> GetEnumValues()

test/Microsoft.Extensions.Logging.Test/LoggerTest.cs

@@ -26,7 +26,7 @@ public void Log_IgnoresExceptionInIntermediateLoggersAndThrowsAggregateException
             // Assert
             Assert.Equal(new[] { "provider1.Test-Hello!", "provider3.Test-Hello!" }, store);
             Assert.NotNull(aggregateException);
-            Assert.Equal("An error occurred while writing to logger(s).", aggregateException.Message);
+            Assert.StartsWith("An error occurred while writing to logger(s).", aggregateException.Message);
             Assert.Equal(1, aggregateException.InnerExceptions.Count);
             var exception = aggregateException.InnerExceptions[0];
             Assert.Equal("provider2.Test-Error occurred while logging data.", exception.Message);
@@ -49,7 +49,7 @@ public void BeginScope_IgnoresExceptionInIntermediateLoggersAndThrowsAggregateEx
             // Assert
             Assert.Equal(new[] { "provider1.Test-Scope1", "provider3.Test-Scope1" }, store);
             Assert.NotNull(aggregateException);
-            Assert.Equal("An error occurred while writing to logger(s).", aggregateException.Message);
+            Assert.StartsWith("An error occurred while writing to logger(s).", aggregateException.Message);
             Assert.Equal(1, aggregateException.InnerExceptions.Count);
             var exception = aggregateException.InnerExceptions[0];
             Assert.Equal("provider2.Test-Error occurred while creating scope.", exception.Message);
@@ -72,7 +72,7 @@ public void IsEnabled_IgnoresExceptionInIntermediateLoggers()
             // Assert
             Assert.Equal(new[] { "provider1.Test-Hello!", "provider3.Test-Hello!" }, store);
             Assert.NotNull(aggregateException);
-            Assert.Equal("An error occurred while writing to logger(s).", aggregateException.Message);
+            Assert.StartsWith("An error occurred while writing to logger(s).", aggregateException.Message);
             Assert.Equal(1, aggregateException.InnerExceptions.Count);
             var exception = aggregateException.InnerExceptions[0];
             Assert.Equal("provider2.Test-Error occurred while checking if logger is enabled.", exception.Message);
@@ -94,7 +94,7 @@ public void Log_AggregatesExceptionsFromMultipleLoggers()
             // Assert
             Assert.Empty(store);
             Assert.NotNull(aggregateException);
-            Assert.Equal("An error occurred while writing to logger(s).", aggregateException.Message);
+            Assert.StartsWith("An error occurred while writing to logger(s).", aggregateException.Message);
             var exceptions = aggregateException.InnerExceptions;
             Assert.Equal(2, exceptions.Count);
             Assert.Equal("provider1.Test-Error occurred while logging data.", exceptions[0].Message);