Addendum to #405

We enabled passing null TraceListener but extension methods were not updated accordingly and would still not allow to pass a null TraceListner.

Author: moozzyk

src/Microsoft.Extensions.Logging.TraceSource/TraceSourceFactoryExtensions.cs

@@ -24,11 +24,6 @@ public static ILoggerFactory AddTraceSource(
                 throw new ArgumentNullException(nameof(switchName));
             }
 
-            if (listener == null)
-            {
-                throw new ArgumentNullException(nameof(listener));
-            }
-
             return factory.AddTraceSource(new SourceSwitch(switchName), listener);
         }
 
@@ -47,11 +42,6 @@ public static ILoggerFactory AddTraceSource(
                 throw new ArgumentNullException(nameof(sourceSwitch));
             }
 
-            if (listener == null)
-            {
-                throw new ArgumentNullException(nameof(listener));
-            }
-
             factory.AddProvider(new TraceSourceLoggerProvider(sourceSwitch, listener));
 
             return factory;

test/Microsoft.Extensions.Logging.Test/TraceSourceLoggerTest.cs

@@ -20,7 +20,7 @@ public static void IsEnabledReturnsCorrectValue()
             var logger = factory.CreateLogger("Test");
 
             // Act
-            factory.AddTraceSource(testSwitch, new ConsoleTraceListener());
+            factory.AddTraceSource(testSwitch, null);
 
             // Assert
             Assert.True(logger.IsEnabled(LogLevel.Critical));
@@ -49,8 +49,8 @@ public static void MultipleLoggers_IsEnabledReturnsCorrectValue(SourceLevels fir
             var logger = factory.CreateLogger("Test");
 
             // Act
-            factory.AddTraceSource(firstSwitch, new ConsoleTraceListener());
-            factory.AddTraceSource(secondSwitch, new ConsoleTraceListener());
+            factory.AddTraceSource(firstSwitch, null);
+            factory.AddTraceSource(secondSwitch, null);
 
             // Assert
             Assert.Equal(expected, logger.IsEnabled(LogLevel.Information));

test/Microsoft.Extensions.Logging.Test/project.json

@@ -16,6 +16,19 @@
   },
   "testRunner": "xunit",
   "frameworks": {
+    "net451": {
+      "dependencies": {
+        "Microsoft.Extensions.Logging.EventLog": "1.0.0-*",
+        "Moq": "4.2.1312.1622",
+        "xunit.runner.console": "2.1.0"
+      },
+      "frameworkAssemblies": {
+        "System.Runtime": {
+          "type": "build"
+        },
+        "System.Threading.Tasks": ""
+      }
+    },
     "netcoreapp1.0": {
       "imports": [
         "dnxcore50",
@@ -29,19 +42,6 @@
         "System.Diagnostics.Process": "4.1.0-*",
         "moq.netcore": "4.4.0-beta8"
       }
-    },
-    "net451": {
-      "dependencies": {
-        "Microsoft.Extensions.Logging.EventLog": "1.0.0-*",
-        "Moq": "4.2.1312.1622",
-        "xunit.runner.console": "2.1.0"
-      },
-      "frameworkAssemblies": {
-        "System.Runtime": {
-          "type": "build"
-        },
-        "System.Threading.Tasks": ""
-      }
     }
   }
 }