Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Discussion, drop vs block on logger #472

Closed
victorhurdugaci opened this issue Jul 29, 2016 · 5 comments
Closed

Discussion, drop vs block on logger #472

victorhurdugaci opened this issue Jul 29, 2016 · 5 comments

Comments

@victorhurdugaci
Copy link
Contributor

From here: #468 (comment)

I would prefer to block instead of dropping message but let's discuss it

@muratg
Copy link

muratg commented Aug 16, 2016

@victorhurdugaci Let's have a look when you're back.

@nblumhardt
Copy link
Contributor

If you head towards the "drop" policy, Serilog.Sinks.Async implements this in BackgroundWorkerSink which can be applied with:

    .WiteTo.Async(a => a.SomeOtherSink())

Functionally, this is pretty much identical to the background sink here. Just thought I'd leave a note in case you're able to make use of it, as any feedback would be valuable to us. Cheers!

@victorhurdugaci
Copy link
Contributor Author

Thanks @nblumhardt, I'll take a look at that. Maybe I can replace our background sink completely with that implementation.

@victorhurdugaci
Copy link
Contributor Author

fyi @pakrym

@muratg muratg modified the milestones: 1.2.0, 1.1.0-preview1 Oct 5, 2016
@muratg muratg added the Perf label Oct 5, 2016
@muratg muratg removed this from the 2.0.0 milestone Mar 29, 2017
@muratg muratg added this to the Backlog milestone Jun 14, 2017
@muratg
Copy link

muratg commented Nov 5, 2018

Closing this as we're preparing to move this repo over to Extensions.

@muratg muratg closed this as completed Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants