Updated action id to be just guid and addressed other feedback.

Author: kichalla

src/Microsoft.AspNet.Mvc.Core/ActionDescriptor.cs

@@ -9,26 +9,17 @@ namespace Microsoft.AspNet.Mvc
 {
     public class ActionDescriptor
     {
-        private readonly string _guid;
-
         public ActionDescriptor()
         {
             Properties = new Dictionary<object, object>();
             RouteValueDefaults = new Dictionary<string, object>(StringComparer.OrdinalIgnoreCase);
-            _guid = Guid.NewGuid().ToString();
+            Id = Guid.NewGuid().ToString();
         }
 
         /// <summary>
         /// Gets an id which uniquely identifies the action.
-        /// It is of the format "<see cref="DisplayName"/>_<see cref="Guid"/>".
         /// </summary>
-        public string Id
-        {
-            get
-            {
-                return string.Format("{0}_{1}", DisplayName, _guid);
-            }
-        }
+        public string Id { get; }
 
         public virtual string Name { get; set; }
 

src/Microsoft.AspNet.Mvc.Core/DefaultActionSelector.cs

@@ -76,8 +76,8 @@ public Task<ActionDescriptor> SelectAsync([NotNull] RouteContext context)
                     Environment.NewLine,
                     finalMatches.Select(a => a.DisplayName));
 
-                _logger.LogError(
-                    $"Request matched multiple actions resulting in ambiguity. Matching actions: {actionNames}");
+                _logger.LogError("Request matched multiple actions resulting in ambiguity. " +
+                    "Matching actions: {AmbiguousActions}", actionNames);
 
                 var message = Resources.FormatDefaultActionSelector_AmbiguousActions(
                     Environment.NewLine,

test/Microsoft.AspNet.Mvc.Core.Test/DefaultActionSelectorTests.cs

@@ -25,26 +25,6 @@ namespace Microsoft.AspNet.Mvc
 {
     public class DefaultActionSelectorTests
     {
-        // When no actions match, MvcRouteHandler logs the message.
-        [Fact]
-        public async void SelectAsync_NoMatchedActions_NothingIsLogged()
-        {
-            // Arrange
-            var sink = new TestSink();
-            var loggerFactory = new TestLoggerFactory(sink);
-
-            var routeContext = CreateRouteContext("POST");
-
-            var actions = new ActionDescriptor[0];
-            var selector = CreateSelector(actions, loggerFactory);
-
-            // Act
-            var action = await selector.SelectAsync(routeContext);
-
-            // Assert
-            Assert.Empty(sink.Scopes);
-        }
-
         [Fact]
         public async void SelectAsync_AmbiguousActions_LogIsCorrect()
         {

test/Microsoft.AspNet.Mvc.Core.Test/MvcRouteHandlerTests.cs

@@ -23,22 +23,17 @@ public async Task RouteAsync_Success_LogsCorrectValues()
             // Arrange
             var sink = new TestSink();
             var loggerFactory = new TestLoggerFactory(sink);
-            var displayName = "A.B.C";
-            var actionDescriptor = new Mock<ActionDescriptor>();
-            actionDescriptor.SetupGet(ad => ad.DisplayName)
-                            .Returns(displayName);
-            var context = CreateRouteContext(actionDescriptor: actionDescriptor.Object, loggerFactory: loggerFactory);
+            var context = CreateRouteContext(loggerFactory: loggerFactory);
             var handler = new MvcRouteHandler();
-            var expectedMessage = $"Executing action {displayName}";
-
+            
             // Act
             await handler.RouteAsync(context);
 
             // Assert
             Assert.Single(sink.Scopes);
-            Assert.StartsWith($"ActionId: {displayName}_", sink.Scopes[0].Scope?.ToString());
+            Assert.StartsWith("ActionId: ", sink.Scopes[0].Scope?.ToString());
             Assert.Single(sink.Writes);
-            Assert.Equal(expectedMessage, sink.Writes[0].State?.ToString());
+            Assert.StartsWith("Executing action ", sink.Writes[0].State?.ToString());
         }
 
         [Fact]
@@ -198,7 +193,7 @@ private RouteContext CreateRouteContext(
         {
             var mockContextAccessor = new Mock<IScopedInstance<ActionContext>>();
 
-            if(actionDescriptor == null)
+            if (actionDescriptor == null)
             {
                 var mockAction = new Mock<ActionDescriptor>();
                 actionDescriptor = mockAction.Object;