Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

column attribute for <textarea> is incorrect #5039

Closed
KLuuKer opened this issue Jul 19, 2016 · 3 comments
Closed

column attribute for <textarea> is incorrect #5039

KLuuKer opened this issue Jul 19, 2016 · 3 comments
Assignees
@dougbu
Labels
3 - Done bug
Milestone
1.1.0-preview1

Comments

@KLuuKer
Copy link

KLuuKer commented Jul 19, 2016 •
edited
Loading

for a <textarea> columns="123" is incorrect it should be cols="123"

Mvc/src/Microsoft.AspNetCore.Mvc.ViewFeatures/ViewFeatures/DefaultHtmlGenerator.cs

Line 661 in a852352

tagBuilder.MergeAttribute("columns", columns.ToString(CultureInfo.InvariantCulture), true);

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea

so according to what spec should the attribute be named columns instead of cols ?
@KLuuKer KLuuKer changed the title column attribute is incorrect column attribute for <textarea> is incorrect Jul 19, 2016
@dougbu
Copy link
Member

dougbu commented Jul 19, 2016

Yeah. Looks like we spell-corrected the attribute name way back when (112a5dd) 😦

@Eilon Eilon added this to the 1.1.0 milestone Jul 19, 2016
@Eilon Eilon added bug 1 - Ready up-for-grabs Members of our awesome commnity can handle this issue labels Jul 19, 2016
@iscifoni iscifoni mentioned this issue Jul 20, 2016
Merged
@dougbu
Copy link
Member

dougbu commented Jul 20, 2016

581a5ea

@dougbu dougbu closed this as completed Jul 20, 2016
@dougbu dougbu added 3 - Done and removed 1 - Ready up-for-grabs Members of our awesome commnity can handle this issue labels Jul 20, 2016
@dougbu
Copy link
Member

dougbu commented Jul 20, 2016

Thanks @iscifoni ❕

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
3 - Done bug
Projects
None yet
Milestone
1.1.0-preview1
Development

No branches or pull requests
3 participants
@Eilon @dougbu @KLuuKer