Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Flaky test: OnProvidersExecuting_CachesEntries #8186

Closed
ryanbrandenburg opened this issue Aug 1, 2018 · 7 comments
Closed

Flaky test: OnProvidersExecuting_CachesEntries #8186

ryanbrandenburg opened this issue Aug 1, 2018 · 7 comments
Assignees
Labels
Milestone

Comments

@ryanbrandenburg
Copy link
Contributor

This test fails occasionally with the following error:

System.BadImageFormatException : The signature is incorrect.

Other tests within that build may have failed with a similar message, but they are not listed here. Check the link above for more info.

CC @Eilon,@muratg,@mkArtakMSFT

This issue was made automatically. If there is a problem contact @ryanbrandenburg.

@ryanbrandenburg
Copy link
Contributor Author

Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable "TODO" entries:

  • Is this actually a flaky test?

    • No, this is a regular test failure, fix the test/product (TODO: Link to commit/PR)
    • Yes, proceed below...
  • Is this test failure caused by product code flakiness? (Either this product, or another product this test depends on.)

    • File a bug against the product (TODO: Link to other bug)
    • Is it possible to change the test to avoid the flakiness?
      • Yes? Go to the "Change the test!" section.
      • No?
        • Disable the test (TODO: Link to PR/commit)
        • Wait for other bug to be resolved
        • Wait for us to get build that has the fix
        • Re-enable our test (TODO: Link to PR/commit)
        • Close this bug
  • Is it that the test itself is flaky? This includes external transient problems (e.g. remote server problems, file system race condition, etc.)

    • Is there is a way to change our test to avoid this flakiness?
      • Yes? Change the test!
        • Change the test to avoid the flakiness, for example by using a different test strategy, or by adding retries w/ timeouts (TODO: Link to PR/commit)
        • Run the test 100 times locally as a sanity check.
        • Close this bug
      • No?
        • Delete the test because flaky tests are not useful (TODO: Link to PR/commit)

This comment was made automatically. If there is a problem contact @ryanbrandenburg.

@Eilon
Copy link
Member

Eilon commented Aug 1, 2018

@mkArtakMSFT please assign.

@mkArtakMSFT mkArtakMSFT added task PRI: 1 - Required Must be handled in a reasonable time labels Aug 1, 2018
@mkArtakMSFT mkArtakMSFT added this to the 2.2.0-preview1 milestone Aug 1, 2018
@mkArtakMSFT
Copy link
Member

@pranavkm, can you please look into this? Thanks!

@pranavkm
Copy link
Contributor

pranavkm commented Aug 1, 2018

Issue with Moq - castleproject/Core#193. Using #8157 to track upgrading the dependency.

@ryanbrandenburg
Copy link
Contributor Author

If this is an ongoing issue you're better off leaving this issue open and marking it as blocked. If you close it and it fails again the bot is just going to open up a new issue.

@pranavkm
Copy link
Contributor

pranavkm commented Aug 1, 2018

Assigning to @dougbu. This can be closed when #8157 is fixed.

@dougbu
Copy link
Member

dougbu commented Oct 25, 2018

Closing as the upgrade (dotnet/aspnetcore@904c9d3623) more than two weeks ago seems to have cleared all similar failures.

@dougbu dougbu closed this as completed Oct 25, 2018
@dougbu dougbu added 3 - Done and removed blocked labels Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants