Skip to content
This repository has been archived by the owner on Nov 7, 2018. It is now read-only.

Should custom IConfigureOptions be run for all named instances #188

Closed
HaoK opened this issue May 4, 2017 · 2 comments
Closed

Should custom IConfigureOptions be run for all named instances #188

HaoK opened this issue May 4, 2017 · 2 comments
Assignees
@HaoK
Labels
3 - Done bug
Milestone
2.0.0-preview2

Comments

@HaoK
Copy link
Member

HaoK commented May 4, 2017

https://github.com/aspnet/Options/blob/dev/src/Microsoft.Extensions.Options/OptionsFactory.cs#L36

This isn't necessarily a problem, but we should review this behavior.
@HaoK HaoK self-assigned this May 4, 2017
@HaoK HaoK added this to the 2.0.0 milestone May 4, 2017
@HaoK
Copy link
Member Author

HaoK commented May 4, 2017

The potential change would be to only execute custom IConfigureOptions when creating the name == Options.DefaultName. I think that's the more logical behavior. Where IConfigureOptions only targets the default instance

@HaoK HaoK added the bug label May 4, 2017
@HaoK HaoK modified the milestones: 2.0.0-preview2, 2.0.0 May 15, 2017
@HaoK HaoK added the 3 - Done label May 15, 2017
@HaoK
Copy link
Member Author

HaoK commented May 15, 2017

Fixed with 52ab5f1

@HaoK HaoK closed this as completed May 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HaoK HaoK

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0-preview2
Development

No branches or pull requests
1 participant
@HaoK