You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 7, 2018. It is now read-only.
Snapshot shouldn't responsible for registering IOptionsChangeTokenSource
I think we need to update IOptionsMonitor to use the new 2.0 functionality especially now that logging uses it.
Proposed changes for IOptionsMonitor
Use IOptionsFactory / support names / post configures
Use the IOptionsCache to get live updates / handle cache invalidations (should potentially revisit the config reload token hookup to see if there's any improvements there)
@ajcvickers@divega thoughts? With logging using options monitor, its gone from not very important to super important scenario, and it got 0 love in 2.0 so far...
The text was updated successfully, but these errors were encountered:
Note: if we don't end up updating IOptionsMonitor to use IOptionsCache in 2.0, we should remove the public IOptionsCache since it won't be used anywhere now that Snapshot isn't using it. cc @pakrym
@HaoK I like the idea because if I understand correctly this also helps making things more consistent across all options flavors. It adds to the work that you need to do for 2.0, and I am not sure if that is a good idea 😄
Related #199
Snapshot shouldn't responsible for registering IOptionsChangeTokenSource
I think we need to update IOptionsMonitor to use the new 2.0 functionality especially now that logging uses it.
Proposed changes for
IOptionsMonitor
@ajcvickers @divega thoughts? With logging using options monitor, its gone from not very important to super important scenario, and it got 0 love in 2.0 so far...
The text was updated successfully, but these errors were encountered: