Skip to content
This repository has been archived by the owner on Nov 7, 2018. It is now read-only.

Review usage of options in middleware #45

Closed
HaoK opened this issue Mar 13, 2015 · 1 comment
Closed

Review usage of options in middleware #45

HaoK opened this issue Mar 13, 2015 · 1 comment
Labels
needs design

Comments

@HaoK
Copy link
Member

HaoK commented Mar 13, 2015

Should middleware usage of options be consistent? Auth middlewares are using IOptions, while many others, Diagnostics, Routing, StaticFiles etc are still using instance based options.
@glennc glennc added this to the 1.0.0 Backlog milestone Jul 17, 2015
@HaoK
Copy link
Member Author

HaoK commented Jul 23, 2015

Decided to nuke named options and mostly stop using IOptions in middleware (SharedAuthenticationOptions is an exception)

#74

@HaoK HaoK closed this as completed Jul 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
needs design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidfowl @glennc @HaoK