Skip to content
This repository was archived by the owner on Nov 22, 2018. It is now read-only.

Make request cacheable when it has "no-cache" header #125

Closed
beltoev opened this issue Jun 7, 2017 · 4 comments
Closed

Make request cacheable when it has "no-cache" header #125

beltoev opened this issue Jun 7, 2017 · 4 comments

Comments

@beltoev
Copy link

beltoev commented Jun 7, 2017

Why do we trust the client?

For example, "no-cache" header can be used for the ddos attacks. Besides OutputCacheAttribute (ASP.NET MVC 5) doesn't pay attention to this header.

Can we change the behavior of the attribute or add it to the settings?

@Tratcher
Copy link
Member

Tratcher commented Jun 8, 2017

Yes, this is a basic design question we haven't reconciled yet. The cache was built as a real HTTP cache (that honors client headers), not an output cache (that is only beholden to the server). The only additional feature it has is VaryByQueryKeys.

We either need to pivot the whole component to become a true output cache, or to provide a separate middleware that fulfills that role.

@glennc

@GokGokalp
Copy link

Any news?

@JunTaoLuo JunTaoLuo added this to the Backlog milestone Nov 13, 2017
@JunTaoLuo
Copy link
Contributor

We have not prioritized this work item for the next release. I'm putting this in backlog for now but @muratg may decide to move it out if he disagrees.

@aspnet-hello
Copy link

This issue was moved to dotnet/aspnetcore#2607

@aspnet aspnet locked and limited conversation to collaborators Jan 2, 2018
@aspnet-hello aspnet-hello removed this from the Backlog milestone Jan 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants