Changed log message and added test for log values

Author: kichalla

src/Microsoft.AspNet.Routing/RouteConstraintMatcher.cs

@@ -33,7 +33,7 @@ public static bool Match(IReadOnlyDictionary<string, IRouteConstraint> constrain
                         routeValues.TryGetValue(kvp.Key, out routeValue);
 
                         logger.LogVerbose(
-                            "Route value '{RouteValue}' of key '{RouteKey}' did not match " +
+                            "Route value '{RouteValue}' with key '{RouteKey}' did not match " +
                             "the constraint '{RouteConstraint}'.",
                             routeValue,
                             kvp.Key,

test/Microsoft.AspNet.Routing.Tests/ConstraintMatcherTest.cs

@@ -58,7 +58,7 @@ public void MatchFail_LogsCorrectData()
                 {"b", new FailConstraint()}
             };
             var sink = SetUpMatch(constraints, loggerEnabled: true);
-            var expectedMessage = "Route value 'value' of key 'b' did not match the constraint " +
+            var expectedMessage = "Route value 'value' with key 'b' did not match the constraint " +
                 $"'{typeof(FailConstraint).FullName}'.";
 
             // Assert

test/Microsoft.AspNet.Routing.Tests/Template/TemplateRouteTest.cs

@@ -15,6 +15,7 @@
 using Microsoft.Framework.Logging;
 using Moq;
 using Xunit;
+using Microsoft.Framework.Logging.Internal;
 
 namespace Microsoft.AspNet.Routing.Template
 {
@@ -131,13 +132,33 @@ public async Task RouteAsync_MatchFailOnConstraints_LogsCorrectValues()
                 requestPath: "/Home/Index/Failure",
                 loggerEnabled: true,
                 testSink: sink);
-            var expectedMessage = "Route value 'Failure' of key 'id' did not match the " +
+            var expectedMessage = "Route value 'Failure' with key 'id' did not match the " +
                 $"constraint '{typeof(IntRouteConstraint).FullName}'.";
+            var expectedLogValues = new[]
+            {
+                new KeyValuePair<string, object>("RouteValue", "Failure"),
+                new KeyValuePair<string, object>("RouteKey", "id"),
+                new KeyValuePair<string, object>("RouteConstraint", typeof(IntRouteConstraint).FullName)
+            };
 
             // Assert
             Assert.Empty(sink.Scopes);
             Assert.Single(sink.Writes);
-            Assert.Equal(expectedMessage, sink.Writes[0].State?.ToString());
+            var sinkWrite = sink.Writes[0];
+            Assert.IsType<FormattedLogValues>(sinkWrite.State);
+            var formattedLogValues = (FormattedLogValues)sinkWrite.State;
+            Assert.Equal(expectedMessage, formattedLogValues.ToString());
+            var actualLogValues = formattedLogValues.GetValues();
+            foreach(var expectedPair in expectedLogValues)
+            {
+                Assert.Contains(
+                    actualLogValues, 
+                    (kvp) =>
+                    {
+                        return string.Equals(expectedPair.Key, kvp.Key)
+                        && string.Equals(expectedPair.Value?.ToString(), kvp.Value?.ToString());
+                    });
+            }
         }
 
         [Fact]